Skip to content

Conversation

jopadan
Copy link

@jopadan jopadan commented Feb 25, 2025

changes

  • fix screen size not being updated at window resize event
  • fix size dependent font/rectangle/object draw

example bug list

To reproduce just maximize the example window
shaders_postprocessing
shaders_postprocessing
shaders_postprocessing fixed
shaders_postprocessing_new

@jopadan jopadan force-pushed the master branch 3 times, most recently from dd33270 to 07e5a17 Compare February 26, 2025 18:12
@jopadan jopadan changed the title example resize fixes [examples] resize fixes Feb 26, 2025
@raysan5
Copy link
Owner

raysan5 commented Mar 11, 2025

@jopadan Please, could you provide some comparison images to illustrate the issues those changes are addressing? Those are many examples changes and I'm not sure if so many reviews are required, considering they seem to be targeted for a single platform.

@jopadan
Copy link
Author

jopadan commented Mar 11, 2025

@raysan5 Added images for one example. There are no platform dependent changes in the PR.

@jopadan
Copy link
Author

jopadan commented Apr 7, 2025

Is there any chance of getting a response?

@raysan5
Copy link
Owner

raysan5 commented Apr 7, 2025

@jopadan As I told you those are too many changes for a single PR. I need some time to review them properly. Still wondering why all those changes are required.

@jopadan
Copy link
Author

jopadan commented Apr 9, 2025

@raysan5 All these changes are required and only in examples to fix none adaptive viewport resize/gui element positions.
There are unnecessary calls to GetScreenWidth()/GetScreenHeight() that should be avoided adding event callbacks in order to circumvent performance penalties generated in loops.

@nezvers
Copy link
Contributor

nezvers commented Jul 18, 2025

Looks like only examples are modified. Mostly just replacing screenWidth with `GetScreenWidth() and same for height.

@raysan5
Copy link
Owner

raysan5 commented Jul 30, 2025

I'm afraid I'm not merging this PR, too big and find it confusing. If it is related to HighDPI, it should/could be addressed internally in some other way.

@raysan5 raysan5 closed this Jul 30, 2025
@jopadan
Copy link
Author

jopadan commented Aug 1, 2025

It is in no way related to HIGH_DPI mentioned in #4836. As mentioned earlier it only effects examples and corrects cosmetic HUD size updates. I discovered IsWindowResized() now and will update the examples with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants